l2jserver rev. 8841

Interlude misc fixes:
JavaDocs? fixes.
Formatted L2PcInstance and L2Character classes, if you got troubles with customs use ​Legacy Server Support area.
Fixed all warnings related to the new Eclipse settings (same as current High Five settings).
NPE vulnerabilities.
Useless empty statement.
Indirect static access.
Redundant superinterface.
And some others.
Cleanup.
Organizing Interlude imports.
Organizing Interlude imports, now with special settings for this project.
Now we use -1 for ban, not -100.
Minor cleanup.
Upgrading DocumentParser?, implementing getCurrecntDocument():
JavaDocs? for almost all classes that extends DocumentParser?.
Format and cleanup for almost all classes that extends DocumentParser?.
Fixed typos in variable names at FishData?.
(Code Style) final static to static final declaration (unified).
Fixes for L2Character:
Flagged bad double comparison, added TODO task.
Math round in maxAngleDiff, while using a double variable.
Avoiding "this instanceof".
Avoiding "instanceof".
Avoiding using a loop to copy an array.
L2PcInstance fixes:
Explicit boolean comparison, for example, val == true.
Useless override.
Using loop to copy an array.
Fixes:
Client and server packet fixes.
Equality with literal boolean.
Using charAt(0) rather than startWith(..) for a single character.
Removing unused import.
Quest class:
Comparing strings with equals(String) rather than ==.
Classes from actor package:
Setting _firstCommandChannelAttacked as volatile to make double locking check work properly.
Equality with literal boolean.
Avoiding "this instanceof", where it's possible.
Issuing Config cleanup:
DeleteGmSpawnOnCustom? should have been removed in [4440].
CustomArmorSetsTable? should have been removed in [5232].
Closing ticket #6193, thanks for report.
Organized some files.
Performance fixes:
Replacing String literal can with character literal.
Equality test with boolean literal: false
A class that is not serializable declares a method named serialVersionUID.
Cannot compare strings using the not equals (!= or ==) operator.
Long literals should use "L" for a suffix.
Avoiding extra math at ThreadPoolManager? for each task.
Removed unnecessary casting to super-classes.
Fixing logic in many equals(Object) methods.
Removed unnecessary overridden method.
Removed "update" boolean from Ant Zip Task, because it doesn't build the Zip file properly (doesn't remove the old files).
Minor Fix for skill 914 (thanks badboy29 for report and test).
Added reuseDelay for Mana Potions Skills.
Updated Adena Reward (where is not updated or missing) of 1st Class Transfer Quests.
Updated Exp/Sp/Adena? Reward of 2nd Class Transfer Quests.
Updated Exp Reward of 3rd Class Transfer Quest.
Unseal Zaken/Frintezza/Freya? Cloaks, thanks blacksea.
Fix for NumberFormatException? in AdminAnnouncements?, FullMetal? for report and first implementation.
Even when try-catch may be faster, we need our users to know where they mistaken sending a message with some info.
Closing #6176
Removed "update" boolean from Ant Zip Task, because it doesn't build the Zip file properly (doesn't remove the old files), and few other changes included for database_installers.